Skip to content

Commit

Permalink
Merge pull request #1249 from ProjectMirador/2.1.3
Browse files Browse the repository at this point in the history
2.1.3
  • Loading branch information
rsinghal authored Feb 9, 2017
2 parents a4a7108 + 9cc1954 commit 993b08e
Show file tree
Hide file tree
Showing 51 changed files with 1,444 additions and 14,281 deletions.
28 changes: 27 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,33 @@ Once you have built the necessary files and created a branch for your feature or

Live interactive reloading of the browser each time a file is saved is enabled and used in the `npm start` command. Note that this will require middleware or a [livereload browser extension](http://feedback.livereload.com/knowledgebase/articles/86242-how-do-i-install-and-use-the-browser-extensions).
### Submitting Your Contribution
Since your
### Publishing a New Release
1. Ensure all Tests Pass
All development occurs on the pinned development branch. Ensure that all tests with merged features are passing in travis before moving on to the release process. The release consists of merging the main development branch with master, therefore all changes must be fully integrated and functioning in the development branch.
1. Change Version Number in package.json
If the version number included in the `package.json` does not already accurately reflect the version to be released, be sure to increment the number according to [SemVer](http://semver.org/) conventions. Bump the third number for a small patch that does not change or add any new functionality; bump the second number if the branch includes any new features that do not interfere with or change existing features; and bump the first ("major") version number if the changes to be released break or change the API for existing functionality.
2. Merge Development Branch into Master
3. Create a New Local Tag
After all new changes have been merged into master, checkout master locally, and create a git tag for the new version:
`git checkout master`
`git tag v[VERSION_NUMBER]`
This will give the current state of the project a name and freeze it in time.
4. Push Tag to Github
Now push the tagged version to github (from master):
`git push --tags`

This should cause the new version to appear under the "releases" section of the github project page, and will allow npm to access it in the next step.
5. Publish to NPM
Assuming the commiter has access to the project's package management account on npm, publishing the most recent version requires logging into npm on the command line.
Then simply type `npm publish` to post the new package version to the registry.
To configure your npm user locally, refer to the npm-adduser [documentation](https://docs.npmjs.com/cli/adduser).
6. Create Build and Add it to the New Release
Type npm
7. Update the gh-pages Demo Instance to Show Off the Latest Features
7. Update Release Notes
Using the github commit log, compile a bulleted list of the features and changes added to the new release.
8. Announce New Release on the Mailing Lists and Slack

### Design Review
Design review can happen in one of two ways, though both ways start with an issue or issues describing the interaction requirements. Once an issue has been created for a new UI-heavy feature, whether or not a prototype is complete, the feature goes up for design review. This is generally a three-step process:
1. An announcement about the proposed feature is put out to the Mirador-tech mailing list or on one of the bi-weekly calls with a link to the issue that documents the proposed UI feature, with links to any prototype examples or design references.
Expand Down
5 changes: 3 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,11 @@ module.exports = function(grunt) {
'js/lib/URI.min.js',
'js/lib/mousetrap.min.js',
'js/lib/isfahan.js',
'js/lib/paper-full.min.js',
'js/lib/paper-core.min.js',
'js/lib/spectrum.js',
'js/lib/i18next.min.js',
'js/lib/modernizr.custom.js'
'js/lib/modernizr.custom.js',
'js/lib/sanitize-html.min.js'
],

// source files
Expand Down
1 change: 1 addition & 0 deletions bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"mousetrap": "~1.4.6",
"URIjs": "https://github.com/medialize/URI.js.git#~1.13.2",
"paper": "git://github.com/paperjs/paper.js.git#*",
"sanitize-html": "~1.11.4",
"spectrum": "git://github.com/bgrins/spectrum.git#*",
"qtip2": "~2.2.1"
},
Expand Down
4 changes: 2 additions & 2 deletions css/mirador.css
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ li.highlight {
width:25px;
height:25px;
color:red;
border: 1 px solid red;
border: 1px solid red;
}

.select-results {
Expand Down Expand Up @@ -1967,7 +1967,7 @@ a.mirador-icon-window-menu, a.mirador-icon-view-type {
height: 0px;
}

// qtip overrides.
/* qtip overrides. */
.qtip {
}
.qtip-bootstrap {
Expand Down
4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
{ "manifestUri": "http://manifests.ydc2.yale.edu/manifest/Admont23", "location": "Yale University"},
{ "manifestUri": "http://manifests.ydc2.yale.edu/manifest/Admont43", "location": "Yale University"},
{ "manifestUri": "http://manifests.ydc2.yale.edu/manifest/BeineckeMS10", "location": "Yale University"},
{ "manifestUri": "http://manifests.britishart.yale.edu/manifest/5005", "location": "Yale Center For British Art"},
{ "manifestUri": "http://manifests.britishart.yale.edu/manifest/1474", "location": "Yale Center For British Art"},
{ "manifestUri": "https://manifests.britishart.yale.edu/manifest/5005", "location": "Yale Center For British Art"},
{ "manifestUri": "https://manifests.britishart.yale.edu/manifest/1474", "location": "Yale Center For British Art"},
{ "manifestUri": "http://iiif.bodleian.ox.ac.uk/iiif/manifest/51a65464-6408-4a78-9fd1-93e1fa995b9c.json", "location": "Bodleian Libraries"},
{ "manifestUri": "http://iiif.bodleian.ox.ac.uk/iiif/manifest/f19aeaf9-5aba-4cee-be32-584663ff1ef1.json", "location": "Bodleian Libraries"},
{ "manifestUri": "http://iiif.bodleian.ox.ac.uk/iiif/manifest/3b31c0a9-3dab-4801-b3dc-f2a3e3786d34.json", "location": "Bodleian Libraries"},
Expand Down
38 changes: 38 additions & 0 deletions js/lib/paper-core.min.js

Large diffs are not rendered by default.

Loading

0 comments on commit 993b08e

Please sign in to comment.