Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nest static export SSR specs setup to be within describe block #1074

Closed
wants to merge 2 commits into from
Closed

nest static export SSR specs setup to be within describe block #1074

wants to merge 2 commits into from

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 20, 2023 •
edited
Loading

Related Issue

resolves #1070

Summary of Changes

  1. Properly nesting setup code in SSR static export spec

Hopefully this helps. Will try and re-run the Windows builds a few times to see if it behaves more consistently with this change. 🤞

Runs

  1. Pending
  2. Pending
  3. Pending

@thescientist13 thescientist13 added the chore unit testing, maintenance, etc label Feb 20, 2023
@thescientist13 thescientist13 self-assigned this Feb 20, 2023
@thescientist13 thescientist13 linked an issue Feb 20, 2023 that may be closed by this pull request
GitHub Actions for some SSR specs are timing out (experimental runs are fine) #1070
Closed
@thescientist13
Copy link
Member Author

did the nesting in #1073 and will open a separate enhancement for the copy lifecycle refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
chore unit testing, maintenance, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Actions for some SSR specs are timing out (experimental runs are fine)
1 participant
@thescientist13