Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 1072 serve command not serving prerendered ssr content #1073

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #1072

Summary of Changes

  1. Minor refactoring for hybrid server detection
  2. Added missing test cases to account for why this regression was not already caught within our test suite

@thescientist13 thescientist13 added bug Something isn't working CLI SSR labels Feb 20, 2023
@thescientist13 thescientist13 merged commit 15dac4d into release/0.28.0 Feb 24, 2023
@thescientist13 thescientist13 deleted the bug/issue-1072-serve-command-not-serving-prerendered-SSR-content branch February 24, 2023 03:15
thescientist13 added a commit that referenced this pull request Apr 9, 2023
* fix serving of prerendered SSR pages for serve command

* improve detection of hybrid router for serve command and add static export SSR serve command specs

* nest spec setup inside describe block
thescientist13 added a commit that referenced this pull request Apr 9, 2023
* fix serving of prerendered SSR pages for serve command

* improve detection of hybrid router for serve command and add static export SSR serve command specs

* nest spec setup inside describe block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI SSR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serve command not serving prerendered SSR or static export content
1 participant