Restructure to be compliant with composer #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
added
the
status:needs work
|
Will close this PR and do this at the right time for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work/restructure to support issue #361 .
What did change:
configuration_database) moved to folderresourcesexcept from the folderextensionextensionmoved to rootcomposer.json. Project name follows the attributefileinside theinfo.xml.The way this is currently being reformed is working for us. We did follow the logic of having the project's name based on the short name and not on the extension key (old long name) because we believe it's more consistent and appropriate.
We can alter the name of the folder
resourcesthat keeps the other data as well, accordingly.