Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change statements filter method from GET to POST #349

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

webmaster-cses-org-uk
Copy link
Contributor

Fixes the fact that the form does not submit correctly otherwise.

Tested and working on CiviCRM 5.37.0.

Fixes the fact that the form does not submit correctly otherwise.
wintermoor added a commit to wintermoor/org.project60.banking that referenced this pull request Feb 16, 2022
@jensschuppe jensschuppe added enhancement status:needs review Code needs review and testing labels Sep 7, 2022
@jensschuppe jensschuppe added this to the CiviBanking 1.0 milestone Sep 7, 2022
@bjendres
Copy link
Member

@jensschuppe can you think of any issues with this? I'd like to pull this soon, as #361/#364 will break this MR

@jensschuppe
Copy link
Collaborator

jensschuppe commented Sep 30, 2022

Strange enough this template file contains forms that weren't defined using CiviCRM QuickForm, but this shouldn't bother the controller that much, as long as it pulls out request values from the $_REQUEST superglobal, which is the default when using CRM_Utils_Request::retrieve(). So: no, no objections theoretically.

@bjendres bjendres merged commit fd24c32 into Project60:master Sep 30, 2022
@bjendres
Copy link
Member

So: no, no objections theoretically.

That's good enough for me :)

Thanks @webmaster-cses-org-uk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement status:needs review Code needs review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants