Include information on estimates in table response #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpaz
reviewed
Nov 6, 2018
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| - Table: | |||
| - CHANGED: switch to pre-calculated distances for table responses for large speedup and 10% memory increase. [#5251](https://github.com/Project-OSRM/osrm-backend/pull/5251) | |||
| - ADDED: new parameter `fallback_speed` which will fill `null` cells with estimated value [#5257](https://github.com/Project-OSRM/osrm-backend/pull/5257) | |||
| - ADDED: if `fallback_speed` is used, a new structure `estimated_cells` will describe which cells contain estimated values [#5259](https://github.com/Project-OSRM/osrm-backend/pull/5259) | |||
There was a problem hiding this comment.
Should the estimated_cells feature get a flag of it's own? In some cases this information may not be needed and would be unused extra bytes.
There was a problem hiding this comment.
Let's put that into a different PR!
ghoshkaj
force-pushed
the
danpat_estimation_information
branch
from
4ead990
to
bb74294
Compare
ghoshkaj
force-pushed
the
danpat_estimation_information
branch
from
bb74294
to
925e75e
Compare
|
I've updated the name to |
danpaz
approved these changes
Dec 11, 2018
ghoshkaj
pushed a commit
that referenced
this pull request
Dec 11, 2018
* Revert "Remove estimated_cells value in the response." This reverts commit 364e35a. * Update changelog. * fix linting * adjust fallback_speed check * change [].includes to [].indexOf !== -1 for compatibility with node 4 * change param name * more cuke tests * fix formatting
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Nov 19, 2020
- Changes from 5.20.0
- Features:
- ADDED: all waypoints in responses now contain a distance property between the original coordinate and the snapped location. [Project-OSRM#5255](Project-OSRM#5255)
- ADDED: if `fallback_speed` is used, a new structure `fallback_speed_cells` will describe which cells contain estimated values [Project-OSRM#5259](Project-OSRM#5259)
- Table:
- ADDED: new parameter `scale_factor` which will scale the cell `duration` values by this factor. [Project-OSRM#5298](Project-OSRM#5298)
- FIXED: only trigger `scale_factor` code to scan matrix when necessary. [Project-OSRM#5303](Project-OSRM#5303)
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Nov 19, 2020
- Changes from 5.20.0
- Features:
- ADDED: all waypoints in responses now contain a distance property between the original coordinate and the snapped location. [Project-OSRM#5255](Project-OSRM#5255)
- ADDED: if `fallback_speed` is used, a new structure `fallback_speed_cells` will describe which cells contain estimated values [Project-OSRM#5259](Project-OSRM#5259)
- REMOVED: we no longer publish Node 4 or 6 binary modules (they are still buildable from source) [Project-OSRM#5314](Project-OSRM#5314)
- Table:
- ADDED: new parameter `scale_factor` which will scale the cell `duration` values by this factor. [Project-OSRM#5298](Project-OSRM#5298)
- FIXED: only trigger `scale_factor` code to scan matrix when necessary. [Project-OSRM#5303](Project-OSRM#5303)
- FIXED: fix bug in reverse offset calculation that sometimes lead to negative (and other incorrect) values in distance table results [Project-OSRM#5315](Project-OSRM#5315)
- Docker:
- FIXED: use consistent boost version between build and runtime [Project-OSRM#5311](Project-OSRM#5311)
- FIXED: don't override default permissions on /opt [Project-OSRM#5311](Project-OSRM#5311)
- Matching:
- CHANGED: matching will now consider edges marked with is_startpoint=false, allowing matching over ferries and other previously non-matchable edge types. [Project-OSRM#5297](Project-OSRM#5297)
- Profile:
- ADDED: Parse `source:maxspeed` and `maxspeed:type` tags to apply maxspeeds and add belgian flanders rural speed limit. [Project-OSRM#5217](Project-OSRM#5217)
- CHANGED: Refactor maxspeed parsing to use common library. [Project-OSRM#5144](Project-OSRM#5144)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If the
fallback_speedoption is used, it's useful to know which cells contain estimated information.This PR adds a new data structure to the
tableAPI response that looks like this:UPDATED: param name to
fallback_speed_cellsfromestimated_cells:which are the
row,columnreferences to cells that contain estimated data.Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?