Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes runner tests #362

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Fixes runner tests #362

merged 4 commits into from
Sep 21, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Sep 21, 2021

part of Project-MONAI/MONAI#2985 and Project-MONAI/MONAI#2914

some pip install monai or pip install monai==0.6 break the current testing environment, this PR fixes it.

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ericspod
Copy link
Member

Is this going to be temporary? I thought we wanted to keep the tutorials depending on only the current release and not a dev release.

@wyli
Copy link
Contributor Author

wyli commented Sep 21, 2021

yes, for now we use monai-weekly to demonstrate the latest features as the codebase is under active development. We should use a stable release in the future...

@wyli wyli merged commit 929c8b7 into Project-MONAI:master Sep 21, 2021
@wyli wyli deleted the fixes-runner-tests branch September 21, 2021 13:12
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* fixes unet demo

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes install command

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes reg mednist

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes install commands

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants