Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance logging logic in ConfigWorkflow #7745

Merged
merged 8 commits into from
May 8, 2024
Merged

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented May 7, 2024

When using nvflare with monai bundle, the logging logic may be overrided by the logging logic in the bundle.
Add an option to disable logging logic in the bundle.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some minor comments.

monai/bundle/workflows.py Outdated Show resolved Hide resolved
monai/bundle/workflows.py Outdated Show resolved Hide resolved
KumoLiu and others added 2 commits May 7, 2024 22:03
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 7, 2024

/build

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, some questions

monai/bundle/workflows.py Outdated Show resolved Hide resolved
monai/bundle/workflows.py Outdated Show resolved Hide resolved
monai/bundle/workflows.py Show resolved Hide resolved
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested a review from YuanTingHsieh May 7, 2024 16:44
@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 7, 2024

/build

@KumoLiu KumoLiu enabled auto-merge (squash) May 8, 2024 00:16
@KumoLiu KumoLiu merged commit 32b7754 into Project-MONAI:dev May 8, 2024
28 checks passed
@KumoLiu KumoLiu deleted the nvflare branch May 8, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants