Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Update ClientAlgo #2566

Merged
merged 1 commit into from
May 7, 2024
Merged

[2.4] Update ClientAlgo #2566

merged 1 commit into from
May 7, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Follows Project-MONAI/MONAI#7745 to pass False so MONAI bundle logging will not disable NVFlare logging.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator Author

/build

holgerroth
holgerroth approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@YuanTingHsieh YuanTingHsieh merged commit 7c1731b into NVIDIA:2.4 May 7, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the update_nvflare_monai_client_algo_24 branch May 7, 2024 22:20
YuanTingHsieh added a commit to YuanTingHsieh/NVFlare that referenced this pull request Jul 16, 2024
@YuanTingHsieh
Update ClientAlgo (NVIDIA#2566)
dc945fc
@YuanTingHsieh YuanTingHsieh mentioned this pull request Jul 16, 2024
Merged
6 tasks
YuanTingHsieh added a commit that referenced this pull request Jul 18, 2024
@YuanTingHsieh @chesterxgchen
Update ClientAlgo (#2566) (#2705)
ff4d98a 
Co-authored-by: Chester Chen <512707+chesterxgchen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerroth holgerroth holgerroth approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @holgerroth