-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate kernel size through attention Attention-UNet #7734
Conversation
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
@KumoLiu ready for review |
Hi @Pkaps25 I see that this only changes the internal code by propagating the kernel size value, so this should not affect existing code or saved weights since the default everywhere was 3 and still is. Could you please add some tests which create instances of the network with different kernel values and checks the number of parameters changes? We should ensure this behaviour is captured in the tests which, since they pass, all use only the default value of 3. Thanks! |
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Done! |
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, overall looks good to me.
/build |
2 similar comments
/build |
/build |
Fixes #7726.
Description
Passes the
kernel_size
parameter toConvBlocks
within Attention UNet, creating a net with the expected number of parameters.Using the example in #7726 on this branch:
outputs the expected values:
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.