6676 port generative networks spade #7320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
ericspod
reviewed
Dec 14, 2023
ericspod
reviewed
Dec 14, 2023
ericspod
reviewed
Dec 14, 2023
ericspod
reviewed
Dec 14, 2023
ericspod
approved these changes
Dec 14, 2023
KumoLiu
reviewed
Dec 15, 2023
We definitely will be refactoring a lot of things in this feature branch before merging into dev. There's a lot of structural overlap between networks and redundant block definitions we can consolidate. We'll also do a pass over documentation to make sure it's consistent and complete. |
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <mark@Marks-MacBook-Pro.local>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Mark Graham <markgraham539@gmail.com>
…sgraham/MONAI into 6676_port_generative_networks_spade
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
11 tasks
I, Mark Graham <markgraham539@gmail.com>, hereby add my Signed-off-by to this commit: 171fec8 Signed-off-by: Mark Graham <markgraham539@gmail.com>
for more information, see https://pre-commit.ci
|
Hi @KumoLiu Just a few more components to add (noise schedulers for diffusion models, some Inferers and Engines) and then we can begin the refactor. And to echo Eric, yes, we will do the refactor on this branch. |
|
/build |
1 similar comment
|
/build |
marksgraham
added a commit
to marksgraham/MONAI
that referenced
this pull request
Jan 30, 2024
Towards Project-MONAI#6676 . ### Description This adds SPADE-enabled autoencoder and diffusion_model_unet architectures. They are new implementations for each network, rather than options in the existing network, because @virginiafdez and I felt that adding additional options to the existing networks to enable spade compatibility significantly reduced the readability of them for users who were not interested in SPADE functionality. These are the last networks to be ported over. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Mark Graham <markgraham539@gmail.com> Signed-off-by: Mark Graham <mark@Marks-MacBook-Pro.local> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Mark Graham <markgraham539@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #6676 .
Description
This adds SPADE-enabled autoencoder and diffusion_model_unet architectures. They are new implementations for each network, rather than options in the existing network, because @virginiafdez and I felt that adding additional options to the existing networks to enable spade compatibility significantly reduced the readability of them for users who were not interested in SPADE functionality.
These are the last networks to be ported over.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.