Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3645 Add missing doc-string of args in Compose #3646

Merged
merged 6 commits into from
Jan 12, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jan 12, 2022

Fixes #3645 .

Description

This PR added the missing dos-string to explain Compose args about how to unpack args to chain array transforms, which was found when Yiheng and I prepared the array transform demo of MONAI webinar topic.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 12, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 12, 2022

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@Nic-Ma Nic-Ma enabled auto-merge (squash) January 12, 2022 10:32
@Nic-Ma Nic-Ma merged commit 523a047 into Project-MONAI:dev Jan 12, 2022
wyli pushed a commit that referenced this pull request Jan 21, 2022
Signed-off-by: Nic Ma <nma@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to ignore some args to chain array transforms
2 participants