Enhance pickle module and protocols #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
/build |
wyli
reviewed
Nov 30, 2021
wyli
approved these changes
Nov 30, 2021
wyli
pushed a commit
to patricio-astudillo/MONAI
that referenced
this pull request
Dec 1, 2021
Signed-off-by: Nic Ma <nma@nvidia.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
Dec 1, 2021
…ks (#3419) * Update segresnet_block.py making the activation function a parameter to the class of the ResBlock * Update segresnet.py * passing activation to the residual blocks * little change * signed Signed-off-by: Patricio Astudillo <patricio.astudillo@robovision.ai> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update Signed-off-by: Wenqi Li <wenqil@nvidia.com> * [DLMED] add args and update default (#3418) Signed-off-by: Nic Ma <nma@nvidia.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update docstrings Signed-off-by: Wenqi Li <wenqil@nvidia.com> Co-authored-by: Patricio Astudillo <patricio.astudillo@robovision.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com> Co-authored-by: Nic Ma <nma@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3402 .
Followup PR to update below items:
LRFinder.torch.save, which is2. While the default value of pickle is 4:https://docs.python.org/3/library/pickle.html#pickle.DEFAULT_PROTOCOL
https://pytorch.org/docs/stable/_modules/torch/serialization.html#save
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.