Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postpone deprecated version from 0.8 to 0.9 #3399

Merged
merged 6 commits into from
Nov 25, 2021
Merged

Postpone deprecated version from 0.8 to 0.9 #3399

merged 6 commits into from
Nov 25, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Nov 25, 2021

Description

This PR postponed some deprecated APIs to 0.9.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 25, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 25, 2021

/build

wyli
wyli approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the quick fix, it looks good to me.

@wyli wyli enabled auto-merge (squash) November 25, 2021 12:21
@wyli
Copy link
Contributor

wyli commented Nov 25, 2021

/build

@wyli wyli merged commit dca8b1c into Project-MONAI:dev Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nic-Ma @wyli