Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All transforms support torch and numpy #2949

Merged
merged 20 commits into from
Sep 14, 2021
Merged

All transforms support torch and numpy #2949

merged 20 commits into from
Sep 14, 2021

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Sep 14, 2021 •
edited
Loading

Requires #2922 to simplify the git diff. Fixes #2933.

Description

Convert input to numpy where necessary for transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

rijobro and others added 18 commits September 10, 2021 12:23
@rijobro
AffineGrid, RandAffineGrid, Resample
f0c0af8 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
Merge remote-tracking branch 'MONAI/dev' into torch_Affine_Resample
271e1b5
@rijobro
Affine, RandAffine, Affined, RandAffined
e13bf30 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
deprecate as_tensor_output
ee223ba 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
fixes
2117a1d 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
remove plotting
1615eb6 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
Merge branch 'dev' into torch_Affine_Resample
d95ff3a
@rijobro
Rand2dElastic, Rand3dElastic, Rand2dElasticd, Rand3dElasticd
be99a7e 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
Merge remote-tracking branch 'MONAI/dev' into torch_Affine_Resample
95a0662
@rijobro
CropForeground
135c3ae 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
fix Invertd
449c038 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
Merge remote-tracking branch 'MONAI/dev' into torch_Affine_Resample
e83f8ae
@rijobro
Merge remote-tracking branch 'MONAI/dev' into torch_Affine_Resample
6176295
@wyli
Merge branch 'dev' into torch_Affine_Resample
543daab
@rijobro
fix
7481a2e 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
transforms convert to necessary type
4c59553 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
fix
86ef6b0 
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
Merge branch 'torch_Affine_Resample' into all_transforms_support_torc…
9c59d1c 
…h_and_numpy
Nic-Ma
Nic-Ma approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rijobro ,

Your idea of modifying old transforms also looks good to me.
Thanks.

@wyli wyli enabled auto-merge (squash) September 14, 2021 18:04
@wyli wyli merged commit 7c45d01 into Project-MONAI:dev Sep 14, 2021
@rijobro rijobro deleted the all_transforms_support_torch_and_numpy branch September 15, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MONAI transforms can't only support Tensor backend
3 participants
@rijobro @wyli @Nic-Ma