Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2898 Merge LocalPatchShuffle with RandCoarseDropout #2907

Merged
merged 7 commits into from
Sep 8, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Sep 8, 2021

Fixes #2898 .

Description

This PR merged the LocalPatchShuffle with RandCoarseDropout transforms to make them more clear.
And rename it to RandCoarseShuffle.
The only difference is that the new transform shuffles every channel separately in the same holes, while the original transform creates holes for every channel.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 8, 2021

/black

@wyli
Copy link
Contributor

wyli commented Sep 8, 2021

/build

@madil90
Copy link
Contributor

madil90 commented Sep 8, 2021

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 2898-refactor-holedrop branch from cd10da8 to c3e568a Compare September 8, 2021 15:27
@Nic-Ma Nic-Ma requested a review from wyli September 8, 2021 15:27
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Nic-Ma Nic-Ma enabled auto-merge (squash) September 8, 2021 15:28
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 8, 2021

/black

@Nic-Ma Nic-Ma merged commit 7f3050a into Project-MONAI:dev Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge LocalPatchShuffling into RandCoarseDropout
3 participants