Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2648 add RandCoarseDropout transform #2658

Merged
merged 10 commits into from
Jul 27, 2021
Merged

2648 add RandCoarseDropout transform #2658

merged 10 commits into from
Jul 27, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jul 27, 2021 •
edited by wyli
Loading

part of #2648 .
fixes #2185

Description

This PR implemented the RandCoarseDropout and RandCoarseDropoutd transforms.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 7 commits February 1, 2021 19:15
@Nic-Ma
Merge pull request #19 from Project-MONAI/master
42a45e0 
merge master
@Nic-Ma
Merge pull request #32 from Project-MONAI/master
cd16a13 
merge master
@Nic-Ma
Merge pull request #180 from Project-MONAI/dev
6f87afd 
merge master
@Nic-Ma
Merge pull request #183 from Project-MONAI/dev
d6d7201 
merge master
@Nic-Ma
[DLMED] add RandCoarseDropout
4fafc06 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix typo
0c7c35f 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] add dict version transform
eaa3dea 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma marked this pull request as ready for review July 27, 2021 05:22
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 27, 2021

/black

@Nic-Ma Nic-Ma requested review from wyli, rijobro and ericspod July 27, 2021 05:23
@wyli
Copy link
Contributor

wyli commented Jul 27, 2021

Will this address #2185?

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 27, 2021

Will this address #2185?

Yes, I think so.
If you feel any cases missing, let me add the support.

Thanks.

wyli
wyli approved these changes Jul 27, 2021
View reviewed changes
monai/transforms/intensity/array.py Outdated Show resolved Hide resolved
@wyli
Copy link
Contributor

wyli commented Jul 27, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 27, 2021

/black

@wyli wyli enabled auto-merge (squash) July 27, 2021 16:12
@wyli wyli merged commit c4833f5 into Project-MONAI:dev Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod left review comments

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cutout data augmentation
3 participants
@Nic-Ma @wyli @ericspod