Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deepgrow dataset #1581

Merged
merged 4 commits into from
Feb 20, 2021
Merged

Add deepgrow dataset #1581

merged 4 commits into from
Feb 20, 2021

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Feb 12, 2021 •
edited
Loading

Description

Add dataset functionalities for deepgrow application
This PR is part of the original PR (#1395) with updated tests and docstrings

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@YuanTingHsieh
Add deepgrow dataset
ccd22dd 
Signed-off-by: YuanTingHsieh <yuantinghsieh@gmail.com>
@YuanTingHsieh
Fix CI/CD issue
21f0b7b 
Signed-off-by: YuanTingHsieh <yuantinghsieh@gmail.com>
@SachidanandAlle
Copy link
Contributor

LGTM, we can add the reference of original PR #1395 in the description and assign to MONAI developers for final review

@YuanTingHsieh YuanTingHsieh changed the title [WIP] Add deepgrow dataset Add deepgrow dataset Feb 15, 2021
wyli
wyli reviewed Feb 18, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks please see some comments inline

wyli
wyli approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 1b170d8 into Project-MONAI:master Feb 20, 2021
@wyli wyli mentioned this pull request Feb 20, 2021
Closed
7 tasks
@YuanTingHsieh YuanTingHsieh deleted the add_deepgrow_dataset branch February 27, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SachidanandAlle SachidanandAlle SachidanandAlle left review comments

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanTingHsieh @SachidanandAlle @wyli