Remove IPlatformNavigationService #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The IPlatformNavigationService is a legacy artifact from the initial Prism 7 attempt to update Prism for UWP with a common interface between Xamarin.Forms and UWP. Since this effort was ultimately failed, the INavigationService was moved back to Prism.Forms from Prism.Core. As a result IPlatformNavigationService is no longer needed and ultimately just creates more headaches for people who are using something like Moq for their Unit Tests.
This PR also resolves a secondary issue as the NavigationService was updated during that effort to return a NavigationResult with the Exception. As a result there is no reason for us to use the ILoggerFacade to log any exceptions as the exception is passed back via the NavigationResult and should be handled in the users code.
Bugs Fixed
API Changes
Migrates the IPlatformNavigationService API into the INavigationService
Behavioral Changes
none
PR Checklist