Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove IPlatformNavigation #1990

Closed
dansiegel opened this issue Jan 6, 2020 · 1 comment · Fixed by #2172
Closed

[Enhancement] Remove IPlatformNavigation #1990

dansiegel opened this issue Jan 6, 2020 · 1 comment · Fixed by #2172

Comments

@dansiegel
Copy link
Member

Summary

Since we are no longer trying to share the INavigationService from Prism.Core and INavigationService is back in Prism.Forms we no longer have a hard requirement for IPlatformNavigationService. While this would be another pdb break from 7.X, the 8.0 push would be a good time to remove the API bloat and simply put this in the INavigationService

API Changes

  • Removes IPlatformNavigationService
  • Adds INavigationService.GoBackAsync(INavigationParameters, bool?, bool)
  • Adds INavigationService.GoBackToRoot(INavigationParameters)
  • Adds INavigationService.NavigateAsync(string, INavigationParameters, bool?, bool)
  • Adds INavigationService.NavigateAsync(Uri, INavigationParameters, bool?, bool)

Intended Use Case

Removes issues with Mocking INavigationService where people use these API's where their NavigationService also needed to implement IPlatformNavigationService.

@dansiegel dansiegel added this to the Prism 8.0 milestone Jan 6, 2020
@dansiegel dansiegel self-assigned this Jan 6, 2020
@stale
Copy link

stale bot commented Mar 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant