Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region fixes #2168

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Region fixes #2168

merged 3 commits into from
Aug 20, 2020

Conversation

dansiegel
Copy link
Member

Description of Change

Fixes issues outlined by @brianlagunas
Removes the GitHub Packages distribution that suddenly decided to start failing.

Bugs Fixed

  • Provide links to bugs here

API Changes

Changed:

Using the GenericConstraint where T : View

  • IContainerRegistry IContainerRegistry.RegisterForNavigation => IContainerRegistry IContainerRegistry.RegisterForRegionNavigation

Behavioral Changes

Changes the LayoutViewRegionAdapter, CollectionViewRegionAdapter (not currently utilized), & the ScrollViewRegionAdapter to provide a basic Region

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant