Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Refactor XF Region Adapters to use base Region instead of Active Regions #2167

Closed
dansiegel opened this issue Aug 20, 2020 · 1 comment
Closed

[Task] Refactor XF Region Adapters to use base Region instead of Active Regions #2167

dansiegel opened this issue Aug 20, 2020 · 1 comment
Labels
housekeeping XF

Comments

@dansiegel
Copy link
Member

Description

As noted by @brianlagunas in his Region PR Review the LayoutViewRegionAdapter & ScrollViewRegionAdapter should provide a base Region and not a SingleActiveRegion or AllActiveRegion
@dansiegel
Copy link
Member Author

closed via #2168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
housekeeping XF
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dansiegel