Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacaligo: adding support for pascaligo, http://ligolang.org #1947

Merged
merged 6 commits into from
Jul 11, 2019

Conversation

DefinitelyNotAGoat
Copy link
Contributor

@DefinitelyNotAGoat DefinitelyNotAGoat commented Jun 21, 2019

Summary
This PR adds the language definition for pascaligo, a layer 2 smart contract language for the Tezos blockchain.

http://ligolang.org

@RunDevelopment
Copy link
Member

@DefinitelyNotAGoat Thank you for making this PR.

However, I have a little question: Isn't this language definition basically the combination of PascalLIGO and CameLIGO which are two languages with different syntax?

And a small note: the tests failed because components/prism-ligo.min.js isn't up to date. Rebuilding Prism should fix this issue.

I'll do the full review soon.

@DefinitelyNotAGoat
Copy link
Contributor Author

Thanks @RunDevelopment! So this is actually the pascaligo version so I will edit to make sure that's noted, rebuild and push.

@DefinitelyNotAGoat DefinitelyNotAGoat changed the title ligo: adding support for ligo, http://ligolang.org pacaligo: adding support for pascaligo, http://ligolang.org Jun 25, 2019
@DefinitelyNotAGoat
Copy link
Contributor Author

Rebuilt, and pushed name changes to accurately reflect pascaligo.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DefinitelyNotAGoat Thank you for the clarification!

I left you a few comments.
Also could you please add an example page showing off the main features of the language? (Something like this)

Apart from these two things, really solid work! I'll be looking forward to the final result!

components.json Outdated Show resolved Hide resolved
components/prism-pascaligo.js Outdated Show resolved Hide resolved
components/prism-pascaligo.js Outdated Show resolved Hide resolved
components/prism-pascaligo.js Outdated Show resolved Hide resolved
components/prism-pascaligo.js Outdated Show resolved Hide resolved
components/prism-pascaligo.js Outdated Show resolved Hide resolved
components/prism-pascaligo.js Outdated Show resolved Hide resolved
components/prism-pascaligo.js Outdated Show resolved Hide resolved
tests/languages/pascaligo/builtin_feature.test Outdated Show resolved Hide resolved
tests/languages/pascaligo/function_feature.test Outdated Show resolved Hide resolved
Merge branch 'master' into master.
@DefinitelyNotAGoat
Copy link
Contributor Author

@RunDevelopment thanks for the review.

I added some new changes to correct the issues. Let me know if you need anything else!

Requests include regex improvements,
and formatting.

Merge branch 'master' into master.
@DefinitelyNotAGoat
Copy link
Contributor Author

Thanks for the tips @RunDevelopment! I re-pushed new changes to reflect the change requests.

@RunDevelopment
Copy link
Member

Nice!
Could please also take a look at the PR I send you?

@RunDevelopment
Copy link
Member

I think this is ready.

Thank you for contributing @DefinitelyNotAGoat!

@RunDevelopment RunDevelopment merged commit 858201c into PrismJS:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants