Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pascaligo improvements #1

Merged

Conversation

RunDevelopment
Copy link

Hello @DefinitelyNotAGoat!
While reviewing your branch I also implemented a few improvements while I was at it. This should also address all of my comments here.

There is one major change which is that I removed the variable token. I did this for 2 reasons:

  1. Prism's highlighting should be consistent. Variables were only highlighted at definition but not usage.
  2. It doesn't improve readability because everything which is neither comment nor string nor keyword nor literal nor punctuation/operator is a keyword. Basically, everything which was and was not highlighted as variable is a variable.

I hope that that's ok with you.

Btw. The examples in the LIGO repo are quite useful for testing.

DefinitelyNotAGoat and others added 2 commits July 8, 2019 20:24
Merge branch 'master' into master.
@DefinitelyNotAGoat
Copy link
Owner

Thanks @RunDevelopment! Admittedly, regular expressions are not my strong suit, so I really appreciate this.

@DefinitelyNotAGoat DefinitelyNotAGoat merged commit e42d3ce into DefinitelyNotAGoat:master Jul 11, 2019
@RunDevelopment RunDevelopment deleted the pascaligo branch July 11, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants