Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anonymous user if it's already in database #174

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Fix anonymous user if it's already in database #174

merged 2 commits into from
Apr 19, 2022

Conversation

PierreRambaud
Copy link
Contributor

Questions Answers
Description? If the user exists in the database and we try to reinstall the module, it will change the anonymous password by a real unknown password.
Type? bug fix
How to test? UPDATE `ps_customer` SET`passwd` = 'prestashop' WHERE `ps_customer`.`email` = 'anonymous@psgdpr.com'; then try to uninstall & install the module

@PierreRambaud PierreRambaud mentioned this pull request Apr 14, 2022
@florine2623 florine2623 self-assigned this Apr 15, 2022
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PierreRambaud ,

Thanks for the PR !

Tested with PHP 7.4.
Tested on branch 1.7.8.x and on develop. On both cases, the password is well regenerated with an unknown password.
I uninstalled the module (with/without deleting the module folder) and reinstalled it.

It is QA ✅ !

@Progi1984 Progi1984 added this to the 1.4.2 milestone Apr 19, 2022
@Progi1984 Progi1984 merged commit e83c443 into PrestaShop:dev Apr 19, 2022
@Progi1984
Copy link
Member

Thanks @PierreRambaud & @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants