Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.2 #172

Merged
merged 10 commits into from
Apr 19, 2022
Merged

Release 1.4.2 #172

merged 10 commits into from
Apr 19, 2022

Conversation

PierreRambaud
Copy link
Contributor

Questions Answers
Description? Release a new version

@PierreRambaud PierreRambaud added this to the 1.4.2 milestone Apr 11, 2022
@florine2623 florine2623 self-assigned this Apr 12, 2022
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PierreRambaud ,

Thanks for the PR !

In BO > Modules > psgdpr > Get started Tab, there is just a little wording to correct :
Screenshot 2022-04-12 at 11 42 14

Could you check please ?
Thanks!

@PierreRambaud
Copy link
Contributor Author

Hello @PierreRambaud ,

Thanks for the PR !

In BO > Modules > psgdpr > Get started Tab, there is just a little wording to correct : Screenshot 2022-04-12 at 11 42 14

Could you check please ? Thanks!

Done in #173

Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PierreRambaud ,

Thanks for the PR !

Tested on 1.7.8.x :

I am encountering some issues on develop branch.

@PierreRambaud
Copy link
Contributor Author

@florine2623 I don't manage to reproduce the issue:
image

But I added #174 which should fix one issue

@jsvtrlvrslv
Copy link

Hi,

When the checkbox is ignored, after clicking forward on the form, Chrome cannot find the field marked "required"
chrome_UqSDQWLZbc

@PierreRambaud
Copy link
Contributor Author

Hi,

When the checkbox is ignored, after clicking forward on the form, Chrome cannot find the field marked "required" chrome_UqSDQWLZbc

It's another bug, already present in previous releases, not related to this one. But thank you for noticing us!

Fix anonymous user if it's already in database
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PierreRambaud ,

It is looking good to me.
Tested on PS 1.7.8.x and develop with PHP 7.4. The password is well encrypted ✅
The gdpr blocks on FO customer account is well displayed ✅

I checked :
Actions buttons are working well
Overall features work well too (modified checkbox consent, downloaded data from BO and FO)

It is QA ✅

@jsvtrlvrslv
Copy link

jsvtrlvrslv commented Apr 19, 2022 via email

@biergepo
Copy link

biergepo commented Nov 4, 2022

Hello, after I've upgraded psgdpr module to version 1.4.2, when I click on the button to access to the module's configuration page, it appears an error 500 page. My Prestashop version is 1.7.5.2.
I have activated the debug mode and these are the details of the error:
Unable to generate a URL for the named route admin_customers_view as such route does not exist.pdf
Can anyone help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants