Use AdminController

[matks]

Questions	Answers
Description?	Migrate deprecated ajax_ps_imageslider.php into a controller to comply with PrestaShop/PrestaShop#34578
Type?	improvement
BC breaks?	yes
Deprecations?
Fixed ticket?
Sponsor company	PrestaShop
How to test?	See below

BC Breaks

File ajax_ps_imageslider.php has been removed

How to test?

1. Go to back-office on PrestaShop 9 (develop branch) and click on "Configure" button of ps_imageslider module in Module Manager
2. Use the back-office page to drag-and-drop slides, and update their position. It should work as expected

This PR modified the function that perform the drag-and-drop of the slides, and store the updated positions.

[Hlavtox]

I didn't test it, but I think you need to register it as a hidden tab with $tab->id_parent = -1;, or it won't work. ;-) Example below:

https://github.com/PrestaShop/ps_faviconnotificationbo/blob/62122b3825d25182743acc0187306ecbdeb0b93e/ps_faviconnotificationbo.php#L79

[leemyongpakvn]

I guess @matks wanted to say about version 4.0.0 of this module, because we are in version 3.1.3 now (maybe he did a copy/paste mistake from ps_checkpayment ;)
Actually, we don't need to remove ajax_ps_imageslider.php file immediately, just keep it and add redirect like what we did with ps_checkpayment v2.0.6 in this PR.
Another option is bumping version to 4.0.0 in this PR, but don't release new major version till we have enough major functioning changes as I and @Hlavtox are doing for ps_facetedsearch and ps_googleanalytics.

[matks]

I guess @matks wanted to say about version 4.0.0 of this module, because we are in version 3.1.3 now (maybe he did a copy/paste mistake from ps_checkpayment ;)

It's 100% a copy-paste mistake XD I was lazy to rewrite the PR table from scratch

Actually, we don't need to remove ajax_ps_imageslider.php file immediately, just keep it and add redirect like what we did with ps_checkpayment v2.0.6 in this PR.

Yes I can keep it 👍 for backward compatibility if you guys think it's better

I didn't test it, but I think you need to register it as a hidden tab with $tab->id_parent = -1;, or it won't work. ;-) Example below:

I promise it works 🤔 . I am only using one ajax controller action, and I don't have a dedicated view for this controller, maybe this is why it works?

[leemyongpakvn]

Tested result on my side: update position is not saved to DB; php-cx-fixer warns about tabs indent in function ajaxProcessUpdateSlidesPosition too.

[matks]

ps_checkpayment v2.0.6

1. PHP-CS-Fixer : I'll do it

2. I'm not sure I can add a redirect to ajax_ps_imageslider.php because it handles a POST request, not a GET request. But I can keep the file, deprecated, with an error message.

3. I had to update the JavaScript call, can you check again after clearing your browser cache? And if it does not work, can you check what URL and payload is sent by the JS? "On my computer it works" 😁

[leemyongpakvn]

Even with my suggested tweaks, the new controller is still missing or invalid

[leemyongpakvn]

I think @Hlavtox is right. In BlockReassurance 4.0.0 Release, new-added AdminBlockListingController is added to Tab table by upgrade-4.0.0.php

[Hlavtox]

Ping @matks, can you recheck and register the tab? ;-)

[Hlavtox]

Ping @matks

Inspiration here - https://github.com/PrestaShop/ps_googleanalytics/pull/150/files#diff-60c267745b7ebcfcb8662ad9f161f478303ebdc408ce746539a1a90ee0f646c8
and here - https://github.com/PrestaShop/ps_googleanalytics/pull/150/files#diff-71972a6c76b732eff4b676d5ae76000defab930600bfb761dd65689225fce05e

[florine2623]

Hello @matks ,

Upgrade to v3.2.0 OK

I can only drag and drop the sliders once, after I add another slide, I can't drag n drop anymore.

Screen.Recording.2024-09-12.at.10.35.31.mov

Could you check ?
Thanks :)

[Hlavtox]

Issue fixed, there was some wrong logic in the conditions that rendered the sorting in the header.

[florine2623]

Thanks @Hlavtox !

LGTM ✅
CRUD sliders, enabled/disabled.
Sliders can be drag n dropped as wanted.

[matks]

Thank you