Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.2.0 #107

Merged
merged 25 commits into from
Sep 16, 2024
Merged

Release 3.2.0 #107

merged 25 commits into from
Sep 16, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Sep 12, 2024

Questions Answers
Description? Release 3.2.0
Type?
BC breaks?
Deprecations?
Fixed ticket?
Sponsor company
How to test?

JoseNOM and others added 23 commits June 9, 2023 22:02
Delete PULL_REQUEST_TEMPLATE.md
Remove useless Google Analytics parameters
 Update build-release.yml using Organization config
It is also necessary to check the case of creating a new slide (addSlide)
…lide-issue-35713

Fix: Adding new image slide in "Image slider" module (ps_imageslider) does not work
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hlavtox Very weird, you have conflicts.

To solve them you can first do a PR merging master into dev . I have no idea how this happened

Hlavtox and others added 2 commits September 14, 2024 19:45
Merge lalala to dev to resolve conflicts
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Sep 14, 2024

@florine2623 Hello Florine, maybe just a quick glance when you just tested it in #96 ? :-)

@florine2623 florine2623 self-assigned this Sep 16, 2024
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Hlavtox ,

Tested the Release.

Bump to 3.2.0 OK
Remove mobile deactivation OK #95
Add new image in slider OK #99
All slides are displayed in BO OK #104
Drag and drop slider in BO OK #96

It is a GO for me ✅
Thanks!

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Sep 16, 2024

@florine2623 Cool, thanks @florine2623! :-)

@Hlavtox Hlavtox merged commit 2fe06c6 into master Sep 16, 2024
18 checks passed
@Hlavtox Hlavtox mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.