Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and update feature flags #681

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Add and update feature flags #681

merged 5 commits into from
Mar 27, 2024

Conversation

ga-devfront
Copy link
Contributor

@ga-devfront ga-devfront commented Mar 26, 2024 •
edited
Loading

Questions Answers
Description? completes the omissions of feature flag changes in versions 8.1.x and 9.x
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #679 (comment) , Fixes PrestaShop/PrestaShop#35748, Fixes PrestaShop/PrestaShop#35727 , Fixes #615
Sponsor company @PrestaShopCorp
How to test? Try to upgrade from 8.0.x to 8.1.x or with zip of 9.x

@ga-devfront ga-devfront added bug Waiting for review Waiting for review labels Mar 26, 2024
@ga-devfront ga-devfront force-pushed the fix/new_feature_flag branch from b165ff2 to 408eee3 Compare March 26, 2024 14:53
@ga-devfront ga-devfront added wip and removed Waiting for review Waiting for review labels Mar 26, 2024
@ga-devfront
Copy link
Contributor Author

I'm reverting the PR to WIP because I realized that there was a lot of missing features in all versions.

@ga-devfront ga-devfront changed the title Add feature flags introduced by v9 Add and update feature flags Mar 26, 2024
@florine2623 florine2623 mentioned this pull request Mar 26, 2024
Closed
2 tasks
@ga-devfront ga-devfront added Waiting for review Waiting for review and removed wip labels Mar 27, 2024
@ga-devfront
Copy link
Contributor Author

The PR is up-to-date, I did a global review from version 1.7.8.x to 9.x (tag by tag) to check all feature flag modifications. There were a lot of omissions on 8.1.x as well as on 9.x. The PR is ready to be reviewed and tested!

@ga-devfront ga-devfront removed the Waiting for review Waiting for review label Mar 27, 2024
@AureRita
Copy link
Contributor

AureRita commented Mar 27, 2024 •
edited
Loading

Hi @ga-devfront

Thank you for your PR ! This correct the issue on Experimented Feature and we can do an upgrade from
8.0.5 -> 8.1.5 -> 9.0.0
8.0.5 -> 9.0.0

But currently when we want to upgrade from

1.7.8.11 to 8.1.5 (with release major) it works and if just after that, if you do the upgrade from 8.1.5 to 9.0.0 (with files) we have this issue :
image

Because this issue doesn't seems to be related of your PR, It's a QA ✔️

and I'll create a new issue

Thank you

@AureRita AureRita mentioned this pull request Mar 27, 2024
Closed
@jolelievre jolelievre merged commit 5284626 into PrestaShop:dev Mar 27, 2024
27 checks passed
@Quetzacoalt91 Quetzacoalt91 mentioned this pull request May 7, 2024
Closed
2 tasks
@matks matks added this to the 5.0.2 milestone Jun 22, 2024
@ga-devfront ga-devfront deleted the fix/new_feature_flag branch October 3, 2024 08:45
@Quetzacoalt91
Copy link
Member

Related to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees
No one assigned
Labels
bug QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
5.0.2
7 participants
@ga-devfront @AureRita @Quetzacoalt91 @jolelievre @M0rgan01 @matks @ps-jarvis