Instantiate AdminKernel #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ga-devfront
commented
Mar 21, 2024
ga-devfront
commented
| Questions | Answers |
|---|---|
| Description? | Instantiate the appropriate kernel based on the environment |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixe issue #35029 |
| Sponsor company | @PrestaShopCorp |
| How to test? |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
M0rgan01
reviewed
Mar 22, 2024
2 tasks
M0rgan01
reviewed
Mar 22, 2024
jolelievre
approved these changes
Mar 22, 2024
Hlavtox
approved these changes
Mar 22, 2024
M0rgan01
approved these changes
Mar 22, 2024
boherm
approved these changes
Mar 25, 2024
|
Hi @ga-devfront Thank you for your PR, Currently, I tried to test your PR. The installation going well until I want to go in my admin panel This is the error showed : Tested on 8.1.5 and 8.0.5 Do you know how we can improve this ? Waiting for feedback |
AureRita
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Seen with @MatShir,
Because this PR correct the initial issue and let us discover another one, we'll validate this PR and create a new issue, So this PR is QA ✔️
Thank you @ga-devfront for your correction !
This was referenced Mar 26, 2024
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.