Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.12.0 #381

Merged
merged 27 commits into from
Feb 11, 2021
Merged

Release 4.12.0 #381

merged 27 commits into from
Feb 11, 2021

Conversation

matks
Copy link
Contributor

@matks matks commented Feb 9, 2021

Questions Answers
Description? Release 4.12.0, needed for PrestaShop/PrestaShop#22668
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Please perform a standard testing campaign for upgrade module release. Only significant change should be #376

matks and others added 21 commits December 2, 2020 17:21
@matks
Add some badges in README
7eab3f8
@matks
Add LICENSE file
d00f76f
@PierreRambaud
Merge pull request #370 from matks/add-more-badges
56d69a3 
Add some badges in README
@PierreRambaud
Merge pull request #371 from matks/add-license
8cd3328 
Add LICENSE file
@matks
Improve README
0c4a6e2
@PierreRambaud
Merge pull request #372 from matks/improve-readme
0970583 
Improve README
@nenes25
Fix error with private method and upgrade
f2095f0
@atomiix
Migrate upgrade test to Github Actions
db74f00
@atomiix
Migrate phpstan to Github Actions
d40089b
@atomiix
Add nightly upgrade results to the nightly-board
2f45e42
@atomiix
Delete travis
8c19e50
@atomiix
Simplify CLI parameters handling
33c257d
@PierreRambaud
Merge pull request #377 from atomiix/travis-to-GA
f6a0ac6 
Add more upgrade tests and switch to Github actions
@atomiix
Clear cache before enabling theme
0e17be6
@atomiix
Use official phpstan with php 7.4
0bbc6f4
@atomiix
Fix phpstan
d3a9d54
@atomiix
Merge pull request #378 from atomiix/fix-phpstan
6789a91 
Fix phpstan tests
@PierreRambaud
Merge pull request #376 from atomiix/fix-enable-theme
9cd76ec 
Clear cache before enabling theme
@PierreRambaud
Merge pull request #374 from nenes25/dev
0384690 
Fix error with private method and upgrade
@matks
Bump v4.12.0
e3e686d
@matks
Merge pull request #380 from matks/bump-v412
76aa8fb 
Bump v4.12.0
@matks
Copy link
Contributor Author

matks commented Feb 9, 2021

@PierreRambaud Should we add index.php files in all .github folders to "protect" them?

@matks matks mentioned this pull request Feb 9, 2021
Closed
13 tasks
Progi1984
Progi1984 reviewed Feb 9, 2021
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
Progi1984
Progi1984 reviewed Feb 9, 2021
View reviewed changes
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small feedback

Progi1984
Progi1984 previously approved these changes Feb 9, 2021
View reviewed changes
PierreRambaud
PierreRambaud previously approved these changes Feb 9, 2021
View reviewed changes
@PierreRambaud PierreRambaud dismissed stale reviews from Progi1984 and themself via b72f76d February 10, 2021 14:29
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Feb 10, 2021
@Robin-Fischer-PS
Copy link
Contributor

Hi @matks !

  • Simple upgrade from 1.7.6.9 to 1.7.7.x : OK
  • Upgrade from 1.7.5.2 to 1.7.7.x, with rollback : OK
  • Simple upgrade from 1.7.4.2 to 1.7.7.x : OK
  • Upgrade from 1.7.3.3 to 1.7.7.x, with rollback : OK
  • Simple upgrade from 1.7.2.4 to 1.7.7.x : OK
  • Upgrade from 1.7.1.2 to 1.7.7.x, with rollback : OK
  • Simple upgrade from 1.7.0.6 to 1.7.7.x : OK
  • Upgrade from 1.6.1.24 to 1.7.7.x : KO (as expected) but rollback is OK.

So it's OK ! QA ✔️

@Progi1984 Progi1984 added this to the 4.12.0 milestone Feb 11, 2021
@Progi1984 Progi1984 merged commit 257d9d4 into master Feb 11, 2021
@Progi1984
Copy link
Member

Thanks @matks & @Robin-Fischer-PS

@matks
Copy link
Contributor Author

matks commented Feb 11, 2021

@Robin-Fischer-PS Thank you so much for the amazing QA work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

@Progi1984 Progi1984 Progi1984 left review comments

@PierreRambaud PierreRambaud PierreRambaud left review comments

Assignees

@Robin-Fischer-PS Robin-Fischer-PS

Labels
QA ✔️
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@matks @Robin-Fischer-PS @Progi1984 @ondrejmirtes @PierreRambaud @atomiix @nenes25