Add more upgrade tests and switch to Github actions #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atomiix
commented
Jan 19, 2021
atomiix
commented
| Questions | Answers |
|---|---|
| Description? | This PR aims to add more tests of upgrades from/to different versions of PrestaShop including nightlies (Nightly tests are run every day and their results are then added to the nightly board). It also migrates tests from travis to Github actions. |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| How to test? | Github actions should be green |
| Possible impacts? |
matks
previously approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Logic is good. I am worried about the fact we depend on the input format of https://api-nightly.prestashop.com/reports and on the output formats of the Nightly board so when these formats change, this CI will go red. But this is for the future.
Progi1984
reviewed
Jan 20, 2021
35 tasks
Progi1984
approved these changes
Jan 26, 2021
PierreRambaud
approved these changes
Jan 26, 2021
|
Thank you @atomiix |
This was referenced Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.