Fixes bug where MinIOCredentials are not correctly resolved when used with S3Bucket

CHANGELOG.md

@@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Fixed bug where incorrect credentials model was selected when `MinIOCredentials` was used with `S3Bucket` - [#254](https://github.com/PrefectHQ/prefect-aws/pull/254)
+
 ### 0.3.1
 
 Released on April 20th, 2023.

prefect_aws/s3.py

@@ -265,6 +265,9 @@ class S3Bucket(WritableFileSystem, WritableDeploymentStorage, ObjectStorageBlock
         ),
     )
 
+    class Config:
+        smart_union = True
+
     # Property to maintain compatibility with storage block based deployments
     @property
     def basepath(self) -> str:

tests/test_s3.py

@@ -585,6 +585,10 @@ def s3_bucket_with_objects(self, s3_bucket_with_object, object_in_folder):
         )
         return _s3_bucket_with_objects
 
+    def test_credentials_are_correct_type(self, credentials):
+        s3_bucket = S3Bucket(bucket_name="bucket", credentials=credentials)
+        assert isinstance(s3_bucket.credentials, type(credentials))
+
     @pytest.mark.parametrize("client_parameters", aws_clients[-1:], indirect=True)
     def test_list_objects_empty(self, s3_bucket_empty, client_parameters):
         assert s3_bucket_empty.list_objects() == []