Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fixes bug where MinIOCredentials are not correctly resolved when used with S3Bucket #254

Merged
merged 2 commits into from
May 2, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented May 2, 2023

Enables smart_union on S3Bucket to ensure that the correct model is chosen when using MinIOCredentials with the S3Bucket.credentials field.

Closes #251

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@desertaxle desertaxle requested a review from a team May 2, 2023 19:59
@desertaxle desertaxle requested a review from a team May 2, 2023 20:10
@desertaxle desertaxle merged commit 4e41e56 into main May 2, 2023
@desertaxle desertaxle deleted the fixs3-bucket-credential-resolution branch May 2, 2023 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bonkers issue with S3Bucket / MinIOCredentials
2 participants