Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/uniswapv3 #39

Merged
merged 12 commits into from
Jun 7, 2024
Merged

Feat/uniswapv3 #39

merged 12 commits into from
Jun 7, 2024

Conversation

Seth-Schmidt
Copy link
Collaborator

#38

Fixes #

Checklist

  • My branch is up-to-date with upstream/main branch.
  • Everything works and tested for major version of Python/NodeJS/Go and above.
  • I ran pre-commit checks against my changes.
  • I've written tests against my changes and all the current present tests are passing.

Current behaviour

There are no references to the UniswapV3 use case in the docs.

New expected behaviour

The UniswapV2 existing use case section has been changed to cover all Uniswap use cases including V3.

Change logs

Added

  • Links to the UniswapV3 compute/config modules

Changed

  • Uniswapv2 Dashboard title to Uniswap Dashboard
  • Changed any references to the UniswapV2 dashboard to also include a reference to V3
  • Updated the example Uniswap dashboard image to the latest version

Deployment Instructions

No changes

@Seth-Schmidt
Copy link
Collaborator Author

Will still need to add a link to the UniV3 dashboard url once it is up and running.

@Seth-Schmidt
Copy link
Collaborator Author

Will still need to add a link to the UniV3 dashboard url once it is up and running.

V3 dashboard links have been added with 835e1fc

Copy link
Contributor

@kanikamishra kanikamishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked for grammar and spelling errors.

@kanikamishra kanikamishra added the documentation Improvements or additions to documentation label Jun 4, 2024
@anomit anomit mentioned this pull request Jun 5, 2024
Copy link
Member

@anomit anomit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving open conversations.

@anomit anomit merged commit bbac1ab into main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants