Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/Integration tests for columnar data #778

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Improvement/Integration tests for columnar data #778

merged 8 commits into from
Oct 14, 2024

Conversation

figueroa1395
Copy link
Contributor

This PR extends the integration tests to columnar based data in the Python side.

@figueroa1395
updated dataset and component types
157f23d 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
minor bug fix
3794515 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
columnar data integration tests
e65dccf 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
formatting
52b2320 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@figueroa1395
Merge branch 'main' into improvement/integration-test-columnar
6eee25e
@figueroa1395 figueroa1395 self-assigned this Oct 11, 2024
@figueroa1395 figueroa1395 added the improvement Improvement on internal implementation label Oct 11, 2024
@figueroa1395 figueroa1395 mentioned this pull request Oct 11, 2024
Merged
@figueroa1395 figueroa1395 marked this pull request as ready for review October 14, 2024 07:24
mgovers
mgovers reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no additional comments aside from the one by nitish

@figueroa1395
Addressed comments
3f2b6f3 
Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nitbharambe nitbharambe added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit b21532b Oct 14, 2024
26 checks passed
@figueroa1395 figueroa1395 deleted the improvement/integration-test-columnar branch October 14, 2024 10:46
This was referenced Oct 16, 2024
Merged
Open
@mgovers mgovers mentioned this pull request Nov 5, 2024
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers left review comments

@nitbharambe nitbharambe nitbharambe approved these changes

Assignees

@figueroa1395 figueroa1395

Labels
improvement Improvement on internal implementation
Projects
Power Grid Model
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@figueroa1395 @mgovers @nitbharambe