Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Permanent update with batch datasets in Mac yields error #796

Open
figueroa1395 opened this issue Oct 21, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@figueroa1395
Copy link
Contributor

Describe the bug

As found in the investigation #790, when doing a permanent simple update model.update() with a batch dataset (batch size > 1), there is a bug that only happens on Mac and on certain architectures that made the feedstock CI crash (not our own).

To Reproduce

A detailed explanation with investigation can be found in #790, but to simply reproduce, make a branch from main and revert 795b7e9, then build and run using the same configuration on Mac as the failed azure pipelines.

Expected behavior

Feedstock CI should not break as this feature is properly tested and passes in our CI.

Additional context

After #790, it was found that permanent updates with batch datasets were not properly tested, and the necesary tests were added in the core in the same PR, showing that the core indeeds support it. Additionally, the root of this issue maybe related or similar to #769.

@figueroa1395 figueroa1395 added the bug Something isn't working label Oct 21, 2024
@mgovers mgovers changed the title [BUG] Simple update with batch datasets in Mac yields error [BUG] Permanent update with batch datasets in Mac yields error Oct 21, 2024
@mgovers
Copy link
Member

mgovers commented Oct 21, 2024

FYI: renamed Simple update to Permanent update because it carries the meaning better. This is not a big problem, just a minor thing. "Simple update" may appear more severe to a user than it actually is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants