fix: reset deletes only sdk files instead of the whole folder #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
approved these changes
May 15, 2024
pauldambra
reviewed
May 15, 2024
| @@ -694,6 +694,18 @@ class PostHogSDKTest: QuickSpec { | |||
| sut.reset() | |||
| sut.close() | |||
| } | |||
|
|
|||
| it("reset deletes posthog files but not other folders") { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #130
PR won't be merged to the main branch since it's a patch and there's the 3.3 alpha.
Will cherry-pick the branch after cutting the patch and make sure the changes make to the main branch
💚 How did you test it?
Running locally and checking cache folders
📝 Checklist