Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAJOR - Deleting Application Support Directory! #130

Closed
nitrag opened this issue May 13, 2024 · 4 comments
Closed

MAJOR - Deleting Application Support Directory! #130

nitrag opened this issue May 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@nitrag
Copy link

nitrag commented May 13, 2024

Version

3.2.4

Steps to Reproduce

  1. Call PostHogSDK.shared.reset()

Expected Result

Only delete PostHog related data

Actual Result

PostHog wipes the entire directory!! Shame on you guys for doing this, we have valuable data in this directory.

func applicationSupportDirectoryURL() -> URL {
let url = FileManager.default.urls(for: .applicationSupportDirectory, in: .userDomainMask).first!
return url.appendingPathComponent(Bundle.main.bundleIdentifier!)
}

@nitrag nitrag added the bug Something isn't working label May 13, 2024
@nitrag nitrag mentioned this issue May 13, 2024
4 tasks
@marandaneto
Copy link
Member

Hi @nitrag let me check this for you.

@marandaneto
Copy link
Member

marandaneto commented May 14, 2024

@nitrag I can confirm the bug, so sorry about that, we'll make sure this won't happen again.
we'll cut a patch #132
just need to add some tests and make sure that there are no side effects, thanks for opening this.

@marandaneto
Copy link
Member

@nitrag
Copy link
Author

nitrag commented May 15, 2024

Thank you for your quick attention to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants