Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple layers for disk storage #1817

Merged
merged 22 commits into from
Oct 17, 2024
Merged

Conversation

fabianmurariu
Copy link
Collaborator

What changes were proposed in this pull request?

make the edge ids global for disk storage

Why are the changes needed?

because our APIs need edge ids to be aligned

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

unit tests

Issues

Are there any further changes required?

@fabianmurariu fabianmurariu changed the title Multiple layers3 Support multiple layers for disk storage Oct 11, 2024
@fabianmurariu fabianmurariu marked this pull request as ready for review October 15, 2024 12:51
Copy link
Collaborator

@ljeub-pometry ljeub-pometry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints from my end, this looks good!

@fabianmurariu fabianmurariu merged commit 8d8c35c into master Oct 17, 2024
19 checks passed
@fabianmurariu fabianmurariu deleted the multiple_layers3 branch October 17, 2024 10:57
@ricopinazo ricopinazo mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants