Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot at/latest #1832

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Snapshot at/latest #1832

merged 7 commits into from
Oct 18, 2024

Conversation

ricopinazo
Copy link
Contributor

@ricopinazo ricopinazo commented Oct 18, 2024

What changes were proposed in this pull request?

This PR adds two new window functions snapshot_at and snapshot_latest

Why are the changes needed?

These two new functions are needed for those cases where users work with graphs that might be event or persistent and they just want to get all of those entities that have not been deleted at some point in time, which corresponds to before(t+1) for event graphs and at for persistent graphs.

Does this PR introduce any user-facing change? If yes is this documented?

Yes, docs were added to rust and python

How was this patch tested?

A snapshot test was added to raphtory/src/db/api/view/time.rs

Are there any further changes required?

No

Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor change and some tests please :)

Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to remove @with_disk_graph for the time being

@ricopinazo ricopinazo merged commit c5cec60 into master Oct 18, 2024
19 checks passed
@ricopinazo ricopinazo deleted the feature/snapshot-at branch October 18, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants