Edge repr layers #1809
Merged
Edge repr layers #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: ffbf9dc | Previous: 41282d0 | Ratio |
|---|---|---|---|
lotr_graph_window_100/has_node_existing |
44 ns/iter (± 5) |
20 ns/iter (± 0) |
2.20 |
This comment was automatically generated by workflow using github-action-benchmark.
miratepuffin
approved these changes
Oct 10, 2024
This was referenced Oct 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add layers to the edge repr to show what layers an edge/exploded edge is present in, e.g.
Why are the changes needed?
Useful to be displayed in the edge summary.
Does this PR introduce any user-facing change? If yes is this documented?
No.
How was this patch tested?
Added a python test file to check the output seems sane on the two types of graph.
Are there any further changes required?
Issue #1808 is a bit related since it involves how properties are displayed across layers. Could do a two-in-one if the solution is not too hard.