PageRank Args, is_self_loop on edge, remove all option<bool>, added bincode version on graph, fix all warns, #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miratepuffin
approved these changes
Feb 20, 2024
…ading in all places, fix issue with bincode saving, fmt, clean all warnings,
Haaroon
changed the title
Haaroon
changed the title
Haaroon
changed the title
…graphs between rust and python
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
…incode version on graph, fix all warns, (#1499) * pagerank additions * fix tests * fix tests * add is_self_loop to edge * fmt * add version to materialize * remove all option<bools> for bool, add force param to loading, fix loading in all places, fix issue with bincode saving, fmt, clean all warnings, * fixed one borked test, one left * fixed all tests * use bincode versino instead of raphtory version * added bincode version with test * fix issues with tests in windows, fix issues in python when binnning graphs between rust and python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PageRank Args, is_self_loop, bincode with version number
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Issues
#1277 #1046 #997
Are there any further changes required?