Add document interface to Graphql #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # raphtory-graphql/src/main.rs # raphtory/src/vectors/mod.rs
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1272 +/- ##
==========================================
+ Coverage 57.07% 57.13% +0.05%
==========================================
Files 173 179 +6
Lines 19499 19623 +124
==========================================
+ Hits 11129 11211 +82
- Misses 8370 8412 +42
☔ View full report in Codecov by Sentry. |
miratepuffin
approved these changes
Sep 21, 2023
# Conflicts: # raphtory/src/search/mod.rs # raphtory/src/vectors/mod.rs
ricopinazo
changed the title
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* re-enable vector tests * reestructure vectors module * add empty graph test * remove embeddings module from raphtory-graphql * expose document interface through GraphQL * split generate_doc into different trait * make DocumentSource private * make EntityDocument public for the crate * expose document id as a vector of strings * fix compilation errors and warnings * ignore empty graph test in vectors module * fix tantivity bug * remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR:
Why are the changes needed?
A document interface is needed in order to be able to refer to the entities in the graph that are involved in the documents. The other changes were just general improvements for the vectors module.
Does this PR introduce any user-facing change? If yes is this documented?
It is early days for this module and docs are still to be done in general
How was this patch tested?
Some tests were reenabled
Issues
Are there any further changes required?
Yes, there are missing docs, missing tests, and missing functionality with issues created already for them