-
Notifications
You must be signed in to change notification settings - Fork 660
Updates for Polymer 3 #1096
Updates for Polymer 3 #1096
Changes from 18 commits
5231e09
de5a683
4fce025
ba09f0b
6e05d99
034c12c
6cc6667
fecc150
e20dddb
8b6957a
bc77f33
dd23723
50cfeb9
ed94a59
766f791
4178618
e231817
eea9e41
689a3de
cb6a684
2464a8c
4837776
974b67e
44bccb4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
BSD 3-Clause License | ||
|
||
Copyright (c) 2018, The Polymer Authors | ||
All rights reserved. | ||
|
||
Redistribution and use in source and binary forms, with or without | ||
modification, are permitted provided that the following conditions are met: | ||
|
||
* Redistributions of source code must retain the above copyright notice, this | ||
list of conditions and the following disclaimer. | ||
|
||
* Redistributions in binary form must reproduce the above copyright notice, | ||
this list of conditions and the following disclaimer in the documentation | ||
and/or other materials provided with the distribution. | ||
|
||
* Neither the name of the copyright holder nor the names of its | ||
contributors may be used to endorse or promote products derived from | ||
this software without specific prior written permission. | ||
|
||
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE | ||
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,18 +45,18 @@ Install [Polymer CLI](https://github.com/Polymer/polymer-cli) using | |
|
||
mkdir my-app | ||
cd my-app | ||
polymer init polymer-2-starter-kit | ||
polymer init polymer-3-starter-kit | ||
|
||
### Start the development server | ||
|
||
This command serves the app at `http://127.0.0.1:8081` and provides basic URL | ||
routing for the app: | ||
|
||
polymer serve | ||
npm start | ||
|
||
### Build | ||
|
||
The `polymer build` command builds your Polymer application for production, using build configuration options provided by the command line or in your project's `polymer.json` file. | ||
The `npm run build` command builds your Polymer application for production, using build configuration options provided by the command line or in your project's `polymer.json` file. | ||
|
||
You can configure your `polymer.json` file to create multiple builds. This is necessary if you will be serving different builds optimized for different browsers. You can define your own named builds, or use presets. See the documentation on [building your project for production](https://www.polymer-project.org/2.0/toolbox/build-for-production) for more information. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I should find the new link for https://www.polymer-project.org/2.0/toolbox/build-for-production. |
||
|
||
|
@@ -79,14 +79,14 @@ Run `polymer help build` for the full list of available options and optimization | |
|
||
This command serves your app. Replace `build-folder-name` with the folder name of the build you want to serve. | ||
|
||
polymer serve build/build-folder-name/ | ||
npm start build/build-folder-name/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this true? i.e. have you tested this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @abdonrd added these as npm scripts in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bicknellr exactly! Use the Polymer CLI installed in the project. Also the users can use the common There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
### Run tests | ||
|
||
This command will run [Web Component Tester](https://github.com/Polymer/web-component-tester) | ||
against the browsers currently installed on your machine: | ||
|
||
polymer test | ||
npm test | ||
|
||
If running Windows you will need to set the following environment variables: | ||
|
||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,10 +85,10 @@ | |
</script> | ||
|
||
<!-- Load webcomponents-loader.js to check and load any polyfills your browser needs --> | ||
<script src="./node_modules/@webcomponents/webcomponentsjs/webcomponents-loader.js"></script> | ||
<script src="node_modules/@webcomponents/webcomponentsjs/webcomponents-loader.js"></script> | ||
|
||
<!-- Load your application shell --> | ||
<script type="module" src="./src/my-app.js"></script> | ||
<script type="module" src="src/my-app.js"></script> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why are the relative paths wrong? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we set it like this and use the base tag to support the PRPL Server? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't think this change makes a difference since it's still a relative URL that uses the base tag. No action needed. |
||
|
||
<!-- Add any global styles for body, document, etc. --> | ||
<style> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file - canonical license file is already referenced at the top of source files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This files allow us to have the GitHub license preview:
Reference: GitHub Help: Adding a license to a repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack on the GitHub license preview, but this is not something we're broadly adopting across our repos at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we leaving the
license
field inpackage.json
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's fine (needed to suppress npm warning).