Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Updates for Polymer 3 #1096

Merged
merged 24 commits into from
Apr 21, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
5231e09
Remove `bower.json`; update `package.json`; use name specifiers.
bicknellr Apr 18, 2018
de5a683
Add `LICENSE`.
bicknellr Apr 18, 2018
4fce025
Fix stray path specifiers.
bicknellr Apr 18, 2018
ba09f0b
Update paths in test files.
bicknellr Apr 18, 2018
6e05d99
Update wct-browser-legacy
bicknellr Apr 18, 2018
034c12c
Add npm description & repository
abdonrd Apr 18, 2018
6cc6667
Update webcomponentsjs version
abdonrd Apr 18, 2018
fecc150
Add the Polymer CLI as devdepency
abdonrd Apr 18, 2018
e20dddb
Restore index.html relative paths
abdonrd Apr 18, 2018
8b6957a
Remove ESLint to simplify (also the actual deps are not updated)
abdonrd Apr 18, 2018
bc77f33
Update LICENSE as GitHub preview compatible
abdonrd Apr 18, 2018
dd23723
Merge PolymerElement & html import
abdonrd Apr 18, 2018
50cfeb9
Update licenses
abdonrd Apr 18, 2018
ed94a59
Sort imports
abdonrd Apr 18, 2018
766f791
Indent html content
abdonrd Apr 18, 2018
4178618
Add src to polymer.json sources
abdonrd Apr 18, 2018
e231817
Remove Polymer CLI from Travis
abdonrd Apr 18, 2018
eea9e41
Merge pull request #1097 from Polymer/polymer-3-more-updates
bicknellr Apr 18, 2018
689a3de
Remove LICENSE file: the correct license is referenced by comments at…
bicknellr Apr 18, 2018
cb6a684
Remove static `is` getters.
bicknellr Apr 19, 2018
2464a8c
Revert date changes in license comments.
bicknellr Apr 20, 2018
4837776
Update polymer-cli.
bicknellr Apr 20, 2018
974b67e
Revert `sources` change in `polymer.json`.
bicknellr Apr 21, 2018
44bccb4
Update `package-lock.json`.
bicknellr Apr 21, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .eslintrc.json

This file was deleted.

2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ cache:
directories:
- node_modules
install:
- npm install -g polymer-cli
- npm install
- polymer install
before_script:
- npm run lint
script:
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,18 @@ Install [Polymer CLI](https://github.com/Polymer/polymer-cli) using

mkdir my-app
cd my-app
polymer init polymer-2-starter-kit
polymer init polymer-3-starter-kit

### Start the development server

This command serves the app at `http://127.0.0.1:8081` and provides basic URL
routing for the app:

polymer serve
npm start

### Build

The `polymer build` command builds your Polymer application for production, using build configuration options provided by the command line or in your project's `polymer.json` file.
The `npm run build` command builds your Polymer application for production, using build configuration options provided by the command line or in your project's `polymer.json` file.

You can configure your `polymer.json` file to create multiple builds. This is necessary if you will be serving different builds optimized for different browsers. You can define your own named builds, or use presets. See the documentation on [building your project for production](https://www.polymer-project.org/2.0/toolbox/build-for-production) for more information.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Expand All @@ -79,14 +79,14 @@ Run `polymer help build` for the full list of available options and optimization

This command serves your app. Replace `build-folder-name` with the folder name of the build you want to serve.

polymer serve build/build-folder-name/
npm start build/build-folder-name/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this true? i.e. have you tested this

Copy link
Contributor

@abdonrd abdonrd Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

screen shot 2018-04-19 at 14 41 56

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdonrd added these as npm scripts in package.json, they use the cli there, and I think this means that you don't have to install the cli globally to run through these instructions anymore.

Copy link
Contributor

@abdonrd abdonrd Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bicknellr exactly! Use the Polymer CLI installed in the project.
It helps to avoid install the Polymer CLI globally. And more now that it is in alpha.

Also the users can use the common npm start, npm test, etc scripts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


### Run tests

This command will run [Web Component Tester](https://github.com/Polymer/web-component-tester)
against the browsers currently installed on your machine:

polymer test
npm test

If running Windows you will need to set the following environment variables:

Expand Down
26 changes: 0 additions & 26 deletions bower.json

This file was deleted.

4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@
</script>

<!-- Load webcomponents-loader.js to check and load any polyfills your browser needs -->
<script src="./node_modules/@webcomponents/webcomponentsjs/webcomponents-loader.js"></script>
<script src="node_modules/@webcomponents/webcomponentsjs/webcomponents-loader.js"></script>

<!-- Load your application shell -->
<script type="module" src="./src/my-app.js"></script>
<script type="module" src="src/my-app.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are the relative paths wrong?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set it like this and use the base tag to support the PRPL Server?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this change makes a difference since it's still a relative URL that uses the base tag. No action needed.


<!-- Add any global styles for body, document, etc. -->
<style>
Expand Down
Loading