Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with finding pcl deployed out of path #1923

Merged
merged 2 commits into from
Jul 4, 2017
Merged

Fix issue with finding pcl deployed out of path #1923

merged 2 commits into from
Jul 4, 2017

Conversation

SergioRAgostinho
Copy link
Member

This allows the specification of PCL_DIR to override the install path generated during compilation.

@taketwo
Copy link
Member

taketwo commented Jul 4, 2017

Won't it be cleaner if we compute PCL_ROOT as relative path to PCLConfig.cmake?

@taketwo
Copy link
Member

taketwo commented Jul 4, 2017

That is, replace the line in question with

get_filename_component(PCL_ROOT "${CMAKE_CURRENT_LIST_DIR}/../.." ABSOLUTE)

@SergioRAgostinho
Copy link
Member Author

Makes sense

@SergioRAgostinho
Copy link
Member Author

Merge squash at the end.

@jspricke jspricke merged commit bb3f6b4 into PointCloudLibrary:master Jul 4, 2017
@taketwo
Copy link
Member

taketwo commented Jul 4, 2017

I guess we need this on the release branch as well?

@jspricke
Copy link
Member

jspricke commented Jul 4, 2017

I would prefer to leave it in master for testing first.

@SergioRAgostinho SergioRAgostinho deleted the find_pcl branch July 4, 2017 14:26
@SergioRAgostinho SergioRAgostinho restored the find_pcl branch July 4, 2017 14:28
@SergioRAgostinho SergioRAgostinho deleted the find_pcl branch July 4, 2017 14:28
@taketwo taketwo mentioned this pull request Jul 17, 2017
Closed
15 tasks
taketwo pushed a commit that referenced this pull request Jul 18, 2017
@SergioRAgostinho @taketwo
Fix issue with finding pcl deployed out of path (#1923)
26803fb 
* fix issue with finding pcl deployed out of path

* The path is set relative to PCLConfig.cmake
UnaNancyOwen pushed a commit to UnaNancyOwen/pcl that referenced this pull request Nov 24, 2017
@SergioRAgostinho @UnaNancyOwen
Fix issue with finding pcl deployed out of path (PointCloudLibrary#1923)
4342798 
* fix issue with finding pcl deployed out of path

* The path is set relative to PCLConfig.cmake
@SergioRAgostinho SergioRAgostinho mentioned this pull request Sep 2, 2018
Merged
dantwinkler added a commit to 6RiverSystems/pcl that referenced this pull request Feb 21, 2019
@dantwinkler
fix: Dependencies (#5)
0c750a4 
* Revert "PLYReader: thread safe colors"

This reverts commit 4c57676 from 1.8.1
release because it breaks ABI of pcl_io.

* Bump version to 1.8.1

* Add new gtest path

* Fix issue with finding pcl deployed out of path (PointCloudLibrary#1923)

* fix issue with finding pcl deployed out of path

* The path is set relative to PCLConfig.cmake

* Fix issue PointCloudLibrary#1674

* Added CUDA compute capability 5.3

* Update Ensenso tutorial for Ensenso X devices

* need to include instantiate.hpp to use PCL_INSTANTIATE

* Fixed error in documentation.

pcl::visualization::createCube was documented incorrectly and there were spelling mistakes.

* Fixed spelling and grammar errors

* Add test for macro _USE_MATH_DEFINES.

* Final changelist update for 1.8.1

* Fix: Install cuda based filters (#1)

* feat: Add install step for io buffers.

* fix: Build on circleci.

* fix: Add build job.

* fix: Fix circleci project.

* fix: Fix docker image name.

* fix: Build using correct docker image.

* fix: Correct env variable name.

* fix: Fixed build script.

* fix: Fix build image name.

* fix: Add directories to .gitignore.

* fix: remove circle

* fix: add x permissions

* fix: build

* fix: upload artifact

* fix: FPM

* fix: FPM

* fix: permissions

* fix: semver

* fix: get version

* fix: github repo for semrel

* fix: make install

* fix: Slim down pcl (no cuda).

* fix: Fix build scripts.

* fix: Add missing build step.

* fix: Fix package name and repo folder.

* fix: Fix package name and repo folder.

* fix: Add features.

* fix: Add surface.

* fix: Use default build settings.

* fix: Turn off VTK.

* fix: Force rebuild.

* fix: Fix build.

* fix: Fix build.

* fix: Fix build.

* fix: Fix build.

* fix: Smaller pcl library.

* fix: Fix build.

* fix: Remove sudo.

* fix: Fix build scripts.

* fix: Fix build scripts.

* fix: Fix build scripts.

* fix: Fix build scripts.

* fix: Fix build scripts.

* fix: Add qhull and png libraries.

* fix: Add zlib library.

* fix: Remove workspace.

* fix: Clean up build script and fix depends.

* fix: Use ccache.

* fix: Fix build permissions.

* fix: Remove jessie build.
dantwinkler added a commit to 6RiverSystems/pcl that referenced this pull request Feb 21, 2019
@dantwinkler
fix: Fix dependencies. (#4)
1ed71f3 
* Revert "PLYReader: thread safe colors"

This reverts commit 4c57676 from 1.8.1
release because it breaks ABI of pcl_io.

* Bump version to 1.8.1

* Add new gtest path

* Fix issue with finding pcl deployed out of path (PointCloudLibrary#1923)

* fix issue with finding pcl deployed out of path

* The path is set relative to PCLConfig.cmake

* Fix issue PointCloudLibrary#1674

* Added CUDA compute capability 5.3

* Update Ensenso tutorial for Ensenso X devices

* need to include instantiate.hpp to use PCL_INSTANTIATE

* Fixed error in documentation.

pcl::visualization::createCube was documented incorrectly and there were spelling mistakes.

* Fixed spelling and grammar errors

* Add test for macro _USE_MATH_DEFINES.

* Final changelist update for 1.8.1

* Fix: Install cuda based filters (#1)

* feat: Add install step for io buffers.

* fix: Build on circleci.

* fix: Add build job.

* fix: Fix circleci project.

* fix: Fix docker image name.

* fix: Build using correct docker image.

* fix: Correct env variable name.

* fix: Fixed build script.

* fix: Fix build image name.

* fix: Add directories to .gitignore.

* fix: remove circle

* fix: add x permissions

* fix: build

* fix: upload artifact

* fix: FPM

* fix: FPM

* fix: permissions

* fix: semver

* fix: get version

* fix: github repo for semrel

* fix: make install

* fix: Slim down pcl (no cuda).

* fix: Fix build scripts.

* fix: Add missing build step.

* fix: Fix package name and repo folder.

* fix: Fix package name and repo folder.

* fix: Add features.

* fix: Add surface.

* fix: Use default build settings.

* fix: Turn off VTK.

* fix: Force rebuild.

* fix: Fix build.

* fix: Fix build.

* fix: Fix build.

* fix: Fix build.

* fix: Smaller pcl library.

* fix: Fix build.

* fix: Remove sudo.

* fix: Fix build scripts.

* fix: Fix build scripts.

* fix: Fix build scripts.

* fix: Fix build scripts.

* fix: Fix build scripts.

* fix: Add qhull and png libraries.

* fix: Add zlib library.

* fix: Remove workspace.

* fix: Clean up build script and fix depends.

* fix: Use ccache.

* fix: Fix build permissions.

* fix: Remove jessie build.

* fix: Use default  step

* fix: Clean up build directory.

* fix: Enable upload to artifactory.
dantwinkler added a commit to 6RiverSystems/pcl that referenced this pull request Feb 26, 2019
@dantwinkler
feat: Release to master. (#3)
cbd8490 
* Revert "PLYReader: thread safe colors"

This reverts commit 4c57676 from 1.8.1
release because it breaks ABI of pcl_io.

* Bump version to 1.8.1

* Add new gtest path

* Fix issue with finding pcl deployed out of path (PointCloudLibrary#1923)

* fix issue with finding pcl deployed out of path

* The path is set relative to PCLConfig.cmake

* Fix issue PointCloudLibrary#1674

* Added CUDA compute capability 5.3

* Update Ensenso tutorial for Ensenso X devices

* need to include instantiate.hpp to use PCL_INSTANTIATE

* Fixed error in documentation.

pcl::visualization::createCube was documented incorrectly and there were spelling mistakes.

* Fixed spelling and grammar errors

* Add test for macro _USE_MATH_DEFINES.

* Final changelist update for 1.8.1

* Fix: Install cuda based filters (#1)

* feat: Add install step for io buffers.

* fix: Build on circleci.

* fix: Add build job.

* fix: Fix circleci project.

* fix: Fix docker image name.

* fix: Build using correct docker image.

* fix: Correct env variable name.

* fix: Fixed build script.

* fix: Fix build image name.

* fix: Add directories to .gitignore.

* fix: remove circle

* fix: add x permissions

* fix: build

* fix: upload artifact

* fix: FPM

* fix: FPM

* fix: permissions

* fix: semver

* fix: get version

* fix: github repo for semrel

* fix: make install

* fix: Slim down pcl (no cuda).

* fix: Fix build scripts.

* fix: Add missing build step.

* fix: Fix package name and repo folder.

* fix: Fix package name and repo folder.

* fix: Add features.

* fix: Add surface.

* fix: Use default build settings.

* fix: Turn off VTK.

* fix: Force rebuild.

* fix: Fix build.

* fix: Fix build.

* fix: Fix build.

* fix: Fix build.

* fix: Smaller pcl library.

* fix: Fix build.

* fix: Remove workspace file.

* fix: Merge master

* fix: Fix clang install

* fix: Run on bionic.

* fix: Remove sudo

* fix: Fix build script.

* fix: Fix debian package name.

* fix: Fix depends install.

* fix: Fix depends install.

* fix: Use xenial.

* fix: Do not use clang-6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioRAgostinho @taketwo @jspricke