Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GASD signature not available for nearest neighbor search using pcl::search::KdTree #2290

Closed
AchimG opened this issue Apr 26, 2018 · 3 comments
Labels
Milestone

Comments

@AchimG
Copy link

AchimG commented Apr 26, 2018

The GASD signatures are not available when using pcl::search::KdTree for nearest neighbor search.

Your Environment

  • Operating System and version: Ubuntu 16.04
  • Compiler: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  • PCL Version: master branch

Context

When working with the GASD global descriptor, a nearest neighbor search has to be performed in the descriptor space. However, using the current version of pcl::search::KdTree leads to compilation errors since KdTree has not been specialized for the GASD signatures.

Possible Solution

Add the GASD features to the point types which are used to specify KdTree during pre-compiling.

@taketwo
Copy link
Member

taketwo commented Apr 26, 2018

Quick fix: include "impl" file for KdTree in your code.

But actually this is a bug. pcl::search::KdTree is instantiated for all point types listed in PCL_POINT_TYPES macro list. This list does not include GASD descriptors, although it should. You are welcome to send a patch adding them to the list. (Also update PCL_FEATURE_POINT_TYPES list for completeness.)

@taketwo taketwo added this to the pcl-1.9.0 milestone Apr 26, 2018
@AchimG
Copy link
Author

AchimG commented Apr 27, 2018

Thanks for the fast reply.

I will work on this and send a patch in the next days.

AchimG pushed a commit to AchimG/pcl that referenced this issue May 2, 2018
…and PCL_FEATURE_POINTTYPES macros.

In addition, GASDSignatures are used to instantiate DefaultFeatureRepresentation.
@taketwo
Copy link
Member

taketwo commented May 2, 2018

Fixed with #2295.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants