-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #1532
Update dependencies #1532
Conversation
Plutip's |
Unfortunately I didn't have enough time to finish this, so I pushed my last results to As discussed in a thread here, the latest versions of cardano-node (8.0.0 and above) require a new version of Ogmios (6.0). This version introduces a lot of breaking changes: most notably, they're using a standard JSON-RPC 2.0 scheme for the websocket messages. There's a beautiful migration guide here: Last status:
What's left:
|
Update posix times to match updated erasummary/startTime fixtures, encoding
flake.nix
Outdated
extra-substituters = [ "https://cache.iog.io" ]; | ||
extra-trusted-public-keys = [ "hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ=" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
$property-name "jsonrpc" | ||
$property-schema jsonRpcType | ||
$property-name "method" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you get this new schema from? Did you adapt it by hand?
hackage-nix = { | ||
url = "github:input-output-hk/hackage.nix"; | ||
flake = false; | ||
}; | ||
haskell-nix = { | ||
url = "github:input-output-hk/haskell.nix"; | ||
inputs.nixpkgs.follows = "nixpkgs"; | ||
inputs.hackage.follows = "hackage-nix"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these guaranteed to be compatible?
package cardano-wallet | ||
optimization: False | ||
package cardano-wallet-core | ||
optimization: False | ||
package cardano-wallet-cli | ||
optimization: False | ||
package cardano-wallet-launcher | ||
optimization: False | ||
package cardano-wallet-core-integration | ||
optimization: False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need these disabled?
…parameter in ListenerSet
Also update blockfrost ProtocolParameters fixture to match Ogmios.
Was needed to decode ogmios response for `nextTx` with mempool tx, which is now encoded as Base16.
Thanks @szg251 for the status comment. Definitely helped to finish the pr. |
@klntsky some easily missable details:
|
# ogmios nixos module (remove and replace with the above after merging and updating) | ||
ogmios-nixos.url = "github:mlabs-haskell/ogmios"; | ||
kupo-nixos = { | ||
url = "github:mlabs-haskell/kupo-nixos/6f89cbcc359893a2aea14dd380f9a45e04c6aa67"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the revision I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szg251 right?
url = "github:input-output-hk/cardano-haskell-packages?ref=repo"; | ||
flake = false; | ||
plutip = { | ||
url = "github:mlabs-haskell/plutip/1bf0b547cd3689c727586abb8385c008fb2a3d1c"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why we fix the revision? @szg251
Updated some of the dependencies:
Blocked by
mlabs-haskell/plutip#183
Pre-review checklist
make format
)## Unreleased
header, using the appropriate sub-headings (### Added
,### Removed
,### Fixed
), and the links to the appropriate issues/PRs have been included