Proper naming for the new helper functions; more newSVpv() references removed. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removed. Perl_sv_peek() now operates internally without allocating new SVs. But then, a single SV is allocated for the result so we can return SvPV_nolen(). Does that configure a memory leak? Perl_sv_peek() already works that way.
|
(this code will remain available if I close the PR, so I am closing it; we do not track issues with GitHub) |
p5p
pushed a commit
that referenced
this pull request
Feb 19, 2016
This has large memory savings, test prog, perl -MTest::More -e"system 'pause'" before 2196KB Private Bytes Win 7 32 bit to after 2092KB. -On a CHEK the refcount is a U32 for memory savings on 64 bit CPUs while SHEKs are Size_t for refcount because of HE struct, on 32 bit Size_t and U32 happen to be the same thing, if there is future integration the refcount members will have to be the same type, then duping a SHEK or a CHEK is the same code, except that HVhek_COMPILING controls whether to aquire OP_REFCNT_LOCK before touching the ref count, in the future with atomic operations, the refcount can be manipulated with atomic operations regardless if it is a SHEK or CHEK since OP_REFCNT_LOCK lines were removed -TODO figure out how to do static const CHEKs, hash member must be 0 since its process specific randomized (rurban's B stores HEKs in RW static memory and fixes up the hash #s at runtime), add test and branch so that refcount isn't read and written or passed to PerlMemShared_free if static flag is on inidicating static const CHEK -TODO Perl_newGP uses CHEKs not CopFILE, no memcpy and add _< that way -TODO optimize the former alloca to smallbuf or Safefree or savestack newx free
This was referenced Oct 18, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 13, 2020
This was referenced Apr 20, 2020
atoomic
added a commit
that referenced
this pull request
Jun 29, 2020
Fixes #5 probably want to split PERL_VERSION_DECIMAL and co to their ownn .h file
atoomic
added a commit
that referenced
this pull request
Jul 1, 2020
Fixes #5 probably want to split PERL_VERSION_DECIMAL and co to their ownn .h file
demerphq
added a commit
that referenced
this pull request
Sep 9, 2022
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
demerphq
added a commit
that referenced
this pull request
Sep 9, 2022
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
demerphq
added a commit
that referenced
this pull request
Sep 12, 2022
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
khwilliamson
pushed a commit
to khwilliamson/perl5
that referenced
this pull request
Oct 18, 2022
source::encoding, to declare the encoding of source
demerphq
added a commit
that referenced
this pull request
Oct 25, 2022
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
demerphq
added a commit
that referenced
this pull request
Nov 5, 2022
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
demerphq
added a commit
that referenced
this pull request
Nov 5, 2022
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
demerphq
added a commit
that referenced
this pull request
Nov 5, 2022
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
demerphq
added a commit
that referenced
this pull request
Nov 5, 2022
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
demerphq
added a commit
that referenced
this pull request
Dec 31, 2022
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
khwilliamson
pushed a commit
to khwilliamson/perl5
that referenced
this pull request
Jan 30, 2023
upgrade Makefile.PL
demerphq
added a commit
that referenced
this pull request
Feb 8, 2023
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
demerphq
added a commit
that referenced
this pull request
Feb 19, 2023
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
demerphq
added a commit
that referenced
this pull request
Feb 20, 2023
For long define statements put the replacement part on their own line. Also wrap comments on long lines.
mauke
added a commit
to mauke/perl5
that referenced
this pull request
Sep 1, 2024
- change $2 to $1 in the replacement part; $2 no longer exists after commit febfc89 - only search for "gh" or "github" at word boundaries; don't replace "gh" in e.g. "high Perl#5" - change `BEGIN{undef $/};` to the `-g` command-line option - remove useless /m flag on the regex (we're not using `^` or `$`)
mauke
added a commit
that referenced
this pull request
Sep 1, 2024
- change $2 to $1 in the replacement part; $2 no longer exists after commit febfc89 - only search for "gh" or "github" at word boundaries; don't replace "gh" in e.g. "high #5" - change `BEGIN{undef $/};` to the `-g` command-line option - remove useless /m flag on the regex (we're not using `^` or `$`)
rawleyfowler
pushed a commit
to rawleyfowler/perl5
that referenced
this pull request
Sep 2, 2024
- change $2 to $1 in the replacement part; $2 no longer exists after commit febfc89 - only search for "gh" or "github" at word boundaries; don't replace "gh" in e.g. "high Perl#5" - change `BEGIN{undef $/};` to the `-g` command-line option - remove useless /m flag on the regex (we're not using `^` or `$`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take on sending patches to https://rt.perl.org/SelfService/Display.html?id=122405, since my git-fu is weak.